CLN: Unify number recognition tests for all parsers #38954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Jan 4, 2021
pandas/io/parsers.py
Outdated
| decimal = re.escape(self.decimal) | ||
| if self.thousands is None: | ||
| regex = fr"^\-?[0-9]*({decimal}[0-9]*)?([0-9](E|e)\-?[0-9]*)?$" | ||
| regex = fr"^[\-|\+]?[0-9]*({decimal}[0-9]*)?([0-9]?(E|e)\-?[0-9]+)?$" |
Member
There was a problem hiding this comment.
is the | necessary inside []?
jbrockmendel
reviewed
Jan 4, 2021
| ("1_,", 1.0), | ||
| ("1_234,56", 1234.56), | ||
| ("1_234,56e0", 1234.56), | ||
| # negative cases; must not parse as float |
Member
There was a problem hiding this comment.
can you add something in the docstring about this, i.e. how to interpret the tuple
Contributor
|
very nice @phofl |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor regex improvements.
Is a fixture the right thing to do here?